iffyio commented on code in PR #1580:
URL:
https://github.com/apache/datafusion-sqlparser-rs/pull/1580#discussion_r1875615805
##########
tests/sqlparser_snowflake.rs:
##########
@@ -2952,3 +2950,33 @@ fn test_sf_double_dot_notation() {
#[test]
fn test_parse_double_dot_notation_wrong_position() {}
+
+#[test]
+fn test_table_sample() {
+ snowflake_and_generic()
+ .verified_stmt("SELECT * FROM testtable AS t TABLESAMPLE BERNOULLI
(10)");
+
+ // In Snowflake we translate implicit table sample method to bernoulli
+ snowflake().one_statement_parses_to(
+ "SELECT * FROM testtable SAMPLE (10)",
+ "SELECT * FROM testtable TABLESAMPLE BERNOULLI (10)",
Review Comment:
Ah yeah so I was rather thinking that ideally we preserve the syntax
roundtrip, even though they'r interchangeable in some dialects
```rust
snowflake_and_generic().verified_stmt("SELECT * FROM testtable TABLESAMPLE
ROW (20.3)");
snowflake_and_generic().verified_stmt("SELECT * FROM testtable SAMPLE BLOCK
(3) SEED (82)");
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For additional commands, e-mail: github-h...@datafusion.apache.org
