andygrove commented on PR #1104: URL: https://github.com/apache/datafusion-comet/pull/1104#issuecomment-2514840362
> Wondering if the performance improvement comes from different numbers of threads? Are the default numbers are the same? Tokio's defaults are to create one worker thread per core for async code (which can be overridden with the `TOKIO_WORKER_THREADS` env var) and an upper limit of 512 blocking threads (but they are created on demand, so they are unlikely to get this high). I didn't make a note of the benchmark settings I used but it was likely 8 cores in 1 executor so that this PR would have changed worker threads from 32 to 8. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
