kazuyukitanimura commented on PR #1104: URL: https://github.com/apache/datafusion-comet/pull/1104#issuecomment-2518770663
> I didn't make a note of the benchmark settings I used but it was likely 8 cores in 1 executor so that this PR would have changed worker threads from 32 to 8. If `COMET_WORKER_THREADS` is set to 1 with the existing local tokio runtime, do we still see the 2% gain? If yes, then we can say that is due to the reduced (less congested) threads. If no, we can say it is thanks to the global runtime? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
