findepi commented on PR #13489: URL: https://github.com/apache/datafusion/pull/13489#issuecomment-2494043790
> We might need to introduce [column index](https://github.com/apache/datafusion/blob/main/datafusion/physical-expr/src/expressions/column.rs#L71) to differentiate them. This works and is definitely easiest to weave into current code, but IMO is very slippery slope. On the last DF contributor call @alamb mentioned many hours spent debugging why column ordinals are incorrect when working on PostgreSQL internals. Being cautious of engineers' sanity I would strongly prefer globally unique symbols, because then errors are possible to catch. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
