jonahgao commented on PR #13489: URL: https://github.com/apache/datafusion/pull/13489#issuecomment-2487708356
> allow creation of schemas for duplicated names I think it's a good idea, as it allows the schema of the top plan to include duplicate names, thereby resolving #6543. We can delay the name ambiguity check until a real column reference occurs. But currently, it seems that this check is not sufficient. For example ```sh DataFusion CLI v43.0.0 > select t.a from (select 1 as a, 2 as a) t; +---+ | a | +---+ | 1 | +---+ 1 row(s) fetched. ``` This query did not return an error like it does in PostgreSQL and before. Perhaps we should improve ambiguity check when searching for field names from schemas after removing `check_names`. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
