blaginin commented on code in PR #13452:
URL: https://github.com/apache/datafusion/pull/13452#discussion_r1848967601
##########
datafusion/functions-nested/src/make_array.rs:
##########
@@ -198,7 +198,6 @@ pub(crate) fn make_array_inner(arrays: &[ArrayRef]) ->
Result<ArrayRef> {
let array = new_null_array(&DataType::Int64, length);
Ok(Arc::new(array_into_list_array_nullable(array)))
}
- LargeList(..) => array_array::<i64>(arrays, data_type),
Review Comment:
I don't think this line was correct. According to the signature, the
function output is always a `List`. However, this one sometimes returns a
`LargeList`.
I added a test to illustrate this:
https://github.com/apache/datafusion/blob/91b468d0f337a73c65021c50ce889890cde9bccf/datafusion/sqllogictest/test_files/array.slt#L1160
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
