jayzhan211 commented on code in PR #13452:
URL: https://github.com/apache/datafusion/pull/13452#discussion_r1847604516
##########
datafusion/expr-common/src/type_coercion/binary.rs:
##########
@@ -1138,27 +1138,44 @@ fn numeric_string_coercion(lhs_type: &DataType,
rhs_type: &DataType) -> Option<D
}
}
+fn coerce_list_children(lhs_field: &FieldRef, rhs_field: &FieldRef) ->
Option<FieldRef> {
+ Some(Arc::new(
+
Arc::unwrap_or_clone(Arc::clone(lhs_field)).with_data_type(comparison_coercion(
Review Comment:
> Also, I think type_union_resolution is a bit more limiting than
comparison_coercion, and so, for example, if I switch to it, the following two
queries will stop working
It indicates we need to handle more coercion for `type_union_resolution`.
`dictionary_comparison_coercion ` should not preserve dict if both are dict.
There is a logic to **optionally preserve dict if one of them is dict, one is
not**
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
