alamb commented on code in PR #13452:
URL: https://github.com/apache/datafusion/pull/13452#discussion_r1848246249
##########
datafusion/expr-common/src/type_coercion/binary.rs:
##########
@@ -1138,27 +1138,44 @@ fn numeric_string_coercion(lhs_type: &DataType,
rhs_type: &DataType) -> Option<D
}
}
+fn coerce_list_children(lhs_field: &FieldRef, rhs_field: &FieldRef) ->
Option<FieldRef> {
+ Some(Arc::new(
+
Arc::unwrap_or_clone(Arc::clone(lhs_field)).with_data_type(comparison_coercion(
Review Comment:
I don't think there is any problem in theory. I am a little fuzzy about what
the semantic meaning of the Field's name in a `DataType::List` means --
sometimes the code is overly pedantic when comparing but I think semantically
two lists are the same if their element's types are the same (and nullness and
metadata). I don't think the field name should be compared
However, I remember there have been issues before on this point
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
