Chen-Yuan-Lai commented on issue #13262: URL: https://github.com/apache/datafusion/issues/13262#issuecomment-2467514433
Yes, I'm working on this, but have some problems: 1. I trying to rename `/column.rs` to `/multi_column/mod.rs`, and move `/group_column.rs` to different module. simultaneously, I've also moved some shared trait and function to `/multi_column/mod.rs`. However, `/multi_column/mod.rs` itself also defines and implements some data structures (e.g.,`GroupValuesColumn`, `GroupIndexView`). It feels too complex as a `mod.rs` file. Should I split it into other files as well? 2. In the original `/group_column.rs`, there were some test cases. After splitting `/group_column.rs` into three modules (`/multi_column/byte.rs`, `/multi_column/byte_view.rs`, and `/multi_column/primitive.rs`), I move the corresponding tests to their respective files. I'm not sure if this is reasonable, or if it would be better to keep all tests together in `multi_column/test.rs`?" -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For additional commands, e-mail: github-h...@datafusion.apache.org
