alamb opened a new issue, #13262: URL: https://github.com/apache/datafusion/issues/13262
### Is your feature request related to a problem or challenge? While reviewing https://github.com/apache/datafusion/pull/12996 I noticed that all the implementations of `GroupColumn` for different types were in [`datafusion/physical-plan/src/aggregates/group_values/group_column.rs`](https://github.com/apache/datafusion/blob/main/datafusion/physical-plan/src/aggregates/group_values/group_column.rs) which is: 1. a single large file 2. Not obvious that it is like an implementation detail of `GroupValuesColumn`: https://github.com/apache/datafusion/blob/main/datafusion/physical-plan/src/aggregates/group_values/column.rs#L94-L93 ### Describe the solution you'd like I would like to propose rearrainging the code: 1. Rename https://github.com/apache/datafusion/blob/main/datafusion/physical-plan/src/aggregates/group_values/column.rs to https://github.com/apache/datafusion/blob/main/datafusion/physical-plan/src/aggregates/group_values/multi_column/mod.rs 2. Move the implementations in datafusion/physical-plan/src/aggregates/group_values/group_column.rs to different modules within https://github.com/apache/datafusion/blob/main/datafusion/physical-plan/src/aggregates/group_values/multi_column (like `primitive.rs`, `bytes.rs`, etc) ### Describe alternatives you've considered _No response_ ### Additional context _No response_ -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For additional commands, e-mail: github-h...@datafusion.apache.org
