Rachelint commented on PR #12996: URL: https://github.com/apache/datafusion/pull/12996#issuecomment-2452991852
> Is it possible to somehow unify GroupValuesColumn and VectorizedGroupValuesColumn ? 🤔I think It can unify simply, `VectorizedGroupValuesColumn::scalarized_intern` is similar as `GroupValuesColumn::intern`. But its logic is a bit more complex, I am afraid performance regression of `streaming aggregation`. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
