Rachelint commented on code in PR #12996:
URL: https://github.com/apache/datafusion/pull/12996#discussion_r1826554952
##########
datafusion/physical-plan/src/aggregates/group_values/mod.rs:
##########
@@ -143,8 +148,12 @@ pub fn new_group_values(schema: SchemaRef) ->
Result<Box<dyn GroupValues>> {
}
}
- if GroupValuesColumn::supported_schema(schema.as_ref()) {
- Ok(Box::new(GroupValuesColumn::try_new(schema)?))
+ if column::supported_schema(schema.as_ref()) {
Review Comment:
> Can you explain here why GroupOrdering::None is required? Is it because
the `VectorizedGroupValuesColumn` doesn't keep the groups in order?
>
> If that is the case, it seems like maybe `emit_n` would never be called 🤔
The situation is just as @jayzhan211 mentioned, and the detail about why
`GroupOrdering::None` needed can also see:
https://github.com/Rachelint/arrow-datafusion/blob/406acb4983efe0c2072c5d7759674eec9db9404a/datafusion/physical-plan/src/aggregates/group_values/column.rs#L792-L834
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
