berkaysynnada commented on code in PR #13005:
URL: https://github.com/apache/datafusion/pull/13005#discussion_r1823902798
##########
datafusion/physical-expr/src/expressions/case.rs:
##########
@@ -80,7 +79,7 @@ enum EvalMethod {
/// [WHEN ...]
/// [ELSE result]
/// END
-#[derive(Debug, Hash)]
+#[derive(Debug, Hash, PartialEq, Eq)]
Review Comment:
How can it permit auto derivation of `PartialEq` for `CaseExpr` 🤔 -- we need
manual impl's for others
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
