alamb commented on code in PR #13005:
URL: https://github.com/apache/datafusion/pull/13005#discussion_r1815619693
##########
datafusion/physical-expr/src/expressions/binary.rs:
##########
@@ -48,11 +47,11 @@ use kernels::{
};
/// Binary expression
-#[derive(Debug, Hash, Clone)]
-pub struct BinaryExpr {
- left: Arc<dyn PhysicalExpr>,
+#[derive(Debug, Hash, Clone, Eq, PartialEq)]
+pub struct BinaryExpr<DynPhysicalExpr: ?Sized = dyn PhysicalExpr> {
Review Comment:
Here is one way that seems to work:
https://github.com/peter-toth/datafusion/pull/5
More verbose, but I think it keeps the structs simpler to understand
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
