Dandandan commented on code in PR #12996:
URL: https://github.com/apache/datafusion/pull/12996#discussion_r1818156207
##########
datafusion/physical-plan/src/aggregates/group_values/group_column.rs:
##########
@@ -287,6 +469,63 @@ where
};
}
+ fn vectorized_equal_to(
Review Comment:
In hash join implementation the equal to is basically using the arrow
kernels `take` (for rows to check) + `eq` + `and` (if multiple columns), which
is I think pretty fast, at least for primitives (and string views, byte/string
might be slower as it needs some more copying). This performed better than the
row-by-row check.
I didn't look to much at this implementation, but does it seem worth trying
to you?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
