Rachelint commented on PR #12996: URL: https://github.com/apache/datafusion/pull/12996#issuecomment-2440105531
It is really to see that the vectorized approach is promising! The rest work is to find why it get `q28` slower. ``` -------------------- Benchmark clickbench_1.json -------------------- ┏━━━━━━━━━━━━━━┳━━━━━━━━━━━━┳━━━━━━━━━━━━━━━━━━━━━━━━┳━━━━━━━━━━━━━━━┓ ┃ Query ┃ main ┃ vectorize-append-value ┃ Change ┃ ┡━━━━━━━━━━━━━━╇━━━━━━━━━━━━╇━━━━━━━━━━━━━━━━━━━━━━━━╇━━━━━━━━━━━━━━━┩ │ QQuery 0 │ 0.78ms │ 0.66ms │ +1.18x faster │ │ QQuery 1 │ 68.16ms │ 67.25ms │ no change │ │ QQuery 2 │ 161.83ms │ 161.80ms │ no change │ │ QQuery 3 │ 186.20ms │ 179.59ms │ no change │ │ QQuery 4 │ 1581.81ms │ 1601.15ms │ no change │ │ QQuery 5 │ 1556.95ms │ 1504.38ms │ no change │ │ QQuery 6 │ 59.36ms │ 58.69ms │ no change │ │ QQuery 7 │ 79.29ms │ 75.72ms │ no change │ │ QQuery 8 │ 1945.74ms │ 1730.29ms │ +1.12x faster │ │ QQuery 9 │ 1958.91ms │ 1912.77ms │ no change │ │ QQuery 10 │ 519.94ms │ 496.55ms │ no change │ │ QQuery 11 │ 592.06ms │ 573.94ms │ no change │ │ QQuery 12 │ 1834.06ms │ 1818.58ms │ no change │ │ QQuery 13 │ 2963.09ms │ 2937.11ms │ no change │ │ QQuery 14 │ 2053.23ms │ 1959.00ms │ no change │ │ QQuery 15 │ 1902.87ms │ 1873.43ms │ no change │ │ QQuery 16 │ 4042.73ms │ 3721.92ms │ +1.09x faster │ │ QQuery 17 │ 3649.27ms │ 3413.73ms │ +1.07x faster │ │ QQuery 18 │ 8286.60ms │ 7555.43ms │ +1.10x faster │ │ QQuery 19 │ 148.06ms │ 143.84ms │ no change │ │ QQuery 20 │ 3241.10ms │ 3225.91ms │ no change │ │ QQuery 21 │ 3879.00ms │ 3893.55ms │ no change │ │ QQuery 22 │ 9109.29ms │ 9306.23ms │ no change │ │ QQuery 23 │ 23670.14ms │ 23590.65ms │ no change │ │ QQuery 24 │ 1166.75ms │ 1126.80ms │ no change │ │ QQuery 25 │ 998.82ms │ 1006.37ms │ no change │ │ QQuery 26 │ 1320.64ms │ 1307.47ms │ no change │ │ QQuery 27 │ 4772.51ms │ 4675.67ms │ no change │ │ QQuery 28 │ 22374.44ms │ 24834.06ms │ 1.11x slower │ │ QQuery 29 │ 902.94ms │ 896.11ms │ no change │ │ QQuery 30 │ 1829.63ms │ 1739.30ms │ no change │ │ QQuery 31 │ 2059.05ms │ 1951.76ms │ +1.05x faster │ │ QQuery 32 │ 7460.76ms │ 7609.67ms │ no change │ │ QQuery 33 │ 9834.20ms │ 9681.51ms │ no change │ │ QQuery 34 │ 9759.46ms │ 9556.88ms │ no change │ │ QQuery 35 │ 2786.28ms │ 2258.62ms │ +1.23x faster │ │ QQuery 36 │ 257.69ms │ 250.87ms │ no change │ │ QQuery 37 │ 155.01ms │ 151.16ms │ no change │ │ QQuery 38 │ 154.50ms │ 147.32ms │ no change │ │ QQuery 39 │ 635.06ms │ 596.76ms │ +1.06x faster │ │ QQuery 40 │ 60.37ms │ 59.58ms │ no change │ │ QQuery 41 │ 53.82ms │ 53.27ms │ no change │ │ QQuery 42 │ 66.93ms │ 63.49ms │ +1.05x faster │ └──────────────┴────────────┴────────────────────────┴───────────────┘ ┏━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━┳━━━━━━━━━━━━━┓ ┃ Benchmark Summary ┃ ┃ ┡━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━╇━━━━━━━━━━━━━┩ │ Total Time (main) │ 140139.34ms │ │ Total Time (vectorize-append-value) │ 139768.84ms │ │ Average Time (main) │ 3259.05ms │ │ Average Time (vectorize-append-value) │ 3250.44ms │ │ Queries Faster │ 9 │ │ Queries Slower │ 1 │ │ Queries with No Change │ 33 │ └───────────────────────────────────────┴─────────────┘ ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
