Omega359 commented on code in PR #13130: URL: https://github.com/apache/datafusion/pull/13130#discussion_r1818126671
########## docs/source/user-guide/sql/scalar_functions_new.md: ########## @@ -2003,12 +2003,13 @@ _Alias of [date_trunc](#date_trunc)._ Converts an integer to RFC3339 timestamp format (`YYYY-MM-DDT00:00:00.000000000Z`). Integers and unsigned integers are interpreted as nanoseconds since the unix epoch (`1970-01-01T00:00:00Z`) return the corresponding timestamp. ``` -from_unixtime(expression) +from_unixtime(expression, timezone) Review Comment: The common way to denote optional parameters is with [, optional_param] ```suggestion from_unixtime(expression[, timezone]) ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For additional commands, e-mail: github-h...@datafusion.apache.org
