Omega359 commented on code in PR #13130:
URL: https://github.com/apache/datafusion/pull/13130#discussion_r1818128242
##########
datafusion/functions/src/datetime/from_unixtime.rs:
##########
@@ -93,12 +124,59 @@ fn get_from_unixtime_doc() -> &'static Documentation {
Documentation::builder()
.with_doc_section(DOC_SECTION_DATETIME)
.with_description("Converts an integer to RFC3339 timestamp format
(`YYYY-MM-DDT00:00:00.000000000Z`). Integers and unsigned integers are
interpreted as nanoseconds since the unix epoch (`1970-01-01T00:00:00Z`) return
the corresponding timestamp.")
- .with_syntax_example("from_unixtime(expression)")
+ .with_syntax_example("from_unixtime(expression, timezone)")
.with_argument(
"expression",
- "Expression to operate on. Can be a constant, column, or
function, and any combination of arithmetic operators."
+ "Expression to operate on. Can be a constant, column, or
function, and any combination of arithmetic operators.",
)
+ .with_argument(
+ "timezone",
+ "Optional timezone to use when converting the integer to a
timestamp. If not provided, the default timezone is UTC.",
+ )
+
.build()
.unwrap()
})
}
+
+#[cfg(test)]
+mod test {
Review Comment:
These tests are great to have but it would be very nice to have a few
additional ones in timestamps.slt as well
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For additional commands, e-mail: github-h...@datafusion.apache.org
