fmeringdal commented on PR #12516: URL: https://github.com/apache/datafusion/pull/12516#issuecomment-2366719666
Ready for another round of review! Changes applied since the first iteration: - `InsertOp` enum has been introduced and replaced the `overwrite` bool. This introduced a few breaking changes as described in the PR description. Any other places I need to document these breaking changes? - Test added to `datafusion/core/tests/user_defined/insert_operation.rs`. - Handle both `REPLACE INTO ...` and `INSERT OR REPLACE INTO ...` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
