fmeringdal commented on code in PR #12516:
URL: https://github.com/apache/datafusion/pull/12516#discussion_r1770514621
##########
datafusion/catalog/src/table.rs:
##########
@@ -273,6 +273,7 @@ pub trait TableProvider: Sync + Send {
_state: &dyn Session,
_input: Arc<dyn ExecutionPlan>,
_overwrite: bool,
+ _replace_into: bool,
Review Comment:
> That shows that a mock up user defined TableProvider will have insert_into
called with the correct value of replace_into when the relevant SQL is planned
Test added in `datafusion/core/tests/user_defined/insert_operation.rs`.
> Can you please document this new parameter and explain what it means
(bonus points for documenting what _overwrite means too)
Documentation added to the variants of the `InsertOp` enum.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
