jayzhan211 commented on PR #12374: URL: https://github.com/apache/datafusion/pull/12374#issuecomment-2363043803
One performance consideration is that [Field::new](https://docs.rs/arrow/latest/arrow/datatypes/struct.Field.html#method.new) allocates a new string on each invocation. > I don't think there is any issue given that we usually require the whole Field Could that be why WindowUDF (and both ScalarUDF and AggregateUDF) preferred to keep the methods separate? > Maybe historically issue? > Lastly, do we want to diverge Aggregate and Window UDFs? I don't think so, they should be separated, no any good reason to mix them -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
