jcsherin commented on code in PR #12374:
URL: https://github.com/apache/datafusion/pull/12374#discussion_r1763242140
##########
datafusion/expr/src/udwf.rs:
##########
@@ -159,13 +161,6 @@ impl WindowUDF {
self.inner.signature()
}
- /// Return the type of the function given its input types
- ///
- /// See [`WindowUDFImpl::return_type`] for more details.
- pub fn return_type(&self, args: &[DataType]) -> Result<DataType> {
- self.inner.return_type(args)
- }
-
Review Comment:
Removed `return_type`.
##########
datafusion/expr/src/udwf.rs:
##########
@@ -178,11 +173,11 @@ impl WindowUDF {
self.inner.partition_evaluator()
}
- /// Returns if column values are nullable for this window function.
+ /// Returns the field of the final result of evaluating this window
function.
///
- /// See [`WindowUDFImpl::nullable`] for more details.
- pub fn nullable(&self) -> bool {
- self.inner.nullable()
Review Comment:
Removed `nullable`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
