andygrove commented on issue #2893:
URL:
https://github.com/apache/datafusion-sqlparser-rs/issues/2893#issuecomment-6797655197
All tests are now passing in DataFusion (except for a dependency check that
cannot pass until there is a published crate for the new parser).
Now that this is fully working, I would like to discuss the parser and
dialect design in detail to get feedback on the approach. I've filed #2910,
covering:
- how the parser is generic over the dialect
- how a dialect overrides a grammar rule so the change applies everywhere
the rule is used
- how a dialect reuses another dialect's rules by delegating to them, one
rule at a time
Perhaps if the approach is acceptable we could start implementing in a
series of self-contained PRs against a new empty branch in the repo so that we
can review each piece as it lands.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
