andygrove commented on issue #2893: URL: https://github.com/apache/datafusion-sqlparser-rs/issues/2893#issuecomment-6770205230
I switched the v2 parser to `Cow` and integrated with DataFusion in draft PR https://github.com/apache/datafusion/pull/27304. Moving to `Cow` did not add as much overhead as I thought it would. One thing I really like about the DF refactor is that there is now an explicit DataFusion parser implementation that extends the DuckDB parser (this one just happened to be the closest in functionality) and then re-uses specific features from other parsers (MySQL, Spark, and Snowflake) to match the current behavior. I think this will make it much easier to document DataFusion's default SQL dialect. I'm now working on getting the all DF tests passing and re-enabling the unparser support, which is temporarily disabled. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
