tlfua commented on PR #7450: URL: https://github.com/apache/datafusion-comet/pull/7450#issuecomment-6755918230
@coderfender Thanks for the review and for adding `run-all-spark-profiles`. Both points are done in [1f54ae08b](https://github.com/apache/datafusion-comet/pull/7450/commits/1f54ae08b352daacbf2781cd4fd716371b170559): 1. The scalar arm now dispatches `ScalarValue::Utf8` and `ScalarValue::LargeUtf8` to a generic `spark_read_side_padding_scalar::<i32>` / `::<i64>` helper, the same way the array arms do, and any other scalar type returns an error instead of falling through to a `LargeUtf8` builder. `pad_strings` now returns an `ArrayRef`, so the all-scalar tail is `ScalarValue::try_from_array(&result, 0)` without the `to_array(1)` step. 2. The `pad_strings` doc now says `min_capacity` only applies when the length is an array and is ignored when it is a scalar. The fork CI run for this commit passed: https://github.com/tlfua/datafusion-comet/actions/runs/42724088108 Since this PR comes from a fork, the upstream workflows for the new commit are waiting for approval: https://github.com/apache/datafusion-comet/actions/runs/42724097999. Could a committer please approve them when convenient, so the `run-all-spark-profiles` matrix can run? Thank you! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
