tlfua commented on PR #7450: URL: https://github.com/apache/datafusion-comet/pull/7450#issuecomment-6671195298
Thanks for the careful check against Spark 4.1.1. Both done in 0ff089d43. 1. `literalStrReason` now reads "Literal values are not supported for the `str` argument." The `Literal` check itself is no longer needed by the kernel, but lifting it moves the literal `str` queries in `string_lpad.sql`/`string_rpad.sql` from `expect_dispatch` to `expect_native` and changes the notes in `expressions.md`, so I opened https://github.com/apache/datafusion-comet/issues/7525 for it. 2. Added your query to both files. It passes in the fork CI: https://github.com/tlfua/datafusion-comet/actions/runs/42112117022 On the other Spark profiles: the fork can't see `run-*` labels, so could a maintainer add `run-all-spark-profiles` to this PR? And I'm happy to open the backports to `branch-1.2` and `branch-1.1` once this lands if the `backport-1.2`/`backport-1.1` labels get added. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
