goldmedal commented on code in PR #12158:
URL: https://github.com/apache/datafusion/pull/12158#discussion_r1747985197
##########
datafusion/sql/tests/cases/plan_to_sql.rs:
##########
@@ -607,6 +609,151 @@ fn sql_round_trip(query: &str, expect: &str) {
assert_eq!(roundtrip_statement.to_string(), expect);
}
+#[test]
+fn test_table_scan_pushdown() -> Result<()> {
+ let schema = Schema::new(vec![
+ Field::new("id", DataType::Utf8, false),
+ Field::new("age", DataType::Utf8, false),
+ ]);
+
+ let scan_with_projection =
+ table_scan(Some("t1"), &schema, Some(vec![0, 1]))?.build()?;
+ let scan_with_projection = plan_to_sql(&scan_with_projection)?;
+ assert_eq!(
+ format!("{}", scan_with_projection),
+ "SELECT t1.id, t1.age FROM t1"
+ );
+
+ let scan_with_no_projection = table_scan(Some("t1"), &schema,
None)?.build()?;
+ let scan_with_no_projection = plan_to_sql(&scan_with_no_projection)?;
+ assert_eq!(format!("{}", scan_with_no_projection), "SELECT * FROM t1");
+
+ let table_scan_with_projection_alias =
+ table_scan(Some("t1"), &schema, Some(vec![0, 1]))?
+ .alias("ta")?
+ .build()?;
+ let table_scan_with_projection_alias =
+ plan_to_sql(&table_scan_with_projection_alias)?;
+ assert_eq!(
+ format!("{}", table_scan_with_projection_alias),
+ "SELECT ta.id, ta.age FROM t1 AS ta"
+ );
+
+ let table_scan_with_no_projection_alias = table_scan(Some("t1"), &schema,
None)?
+ .alias("ta")?
+ .build()?;
+ let table_scan_with_no_projection_alias =
+ plan_to_sql(&table_scan_with_no_projection_alias)?;
+ assert_eq!(
+ format!("{}", table_scan_with_no_projection_alias),
+ "SELECT * FROM t1 AS ta"
+ );
+
+ let query_from_table_scan_with_projection = LogicalPlanBuilder::from(
+ table_scan(Some("t1"), &schema, Some(vec![0, 1]))?.build()?,
+ )
+ .project(vec![wildcard()])?
+ .build()?;
+ let query_from_table_scan_with_projection =
+ plan_to_sql(&query_from_table_scan_with_projection)?;
+ assert_eq!(
+ format!("{}", query_from_table_scan_with_projection),
+ "SELECT * FROM (SELECT t1.id, t1.age FROM t1)"
+ );
+
+ let table_scan_with_filter = table_scan_with_filters(
+ Some("t1"),
+ &schema,
+ None,
+ vec![col("id").gt(col("age"))],
+ )?
+ .build()?;
+ let table_scan_with_filter = plan_to_sql(&table_scan_with_filter)?;
+ assert_eq!(
+ format!("{}", table_scan_with_filter),
+ "SELECT * FROM t1 WHERE (t1.id > t1.age)"
+ );
+
+ let table_scan_with_two_filter = table_scan_with_filters(
+ Some("t1"),
+ &schema,
+ None,
+ vec![col("id").gt(lit(1)), col("age").lt(lit(2))],
+ )?
+ .build()?;
+ let table_scan_with_two_filter = plan_to_sql(&table_scan_with_two_filter)?;
+ assert_eq!(
+ format!("{}", table_scan_with_two_filter),
+ "SELECT * FROM t1 WHERE ((t1.id > 1) AND (t1.age < 2))"
+ );
+
+ // TODO: support filters for table scan with alias
Review Comment:
filed https://github.com/apache/datafusion/issues/12368
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
