goldmedal commented on code in PR #12158:
URL: https://github.com/apache/datafusion/pull/12158#discussion_r1730386778
##########
datafusion/sql/src/unparser/plan.rs:
##########
@@ -507,6 +523,72 @@ impl Unparser<'_> {
}
}
+ fn unparse_table_scan_pushdown(
+ plan: &LogicalPlan,
+ alias: Option<TableReference>,
+ ) -> Result<LogicalPlan> {
+ match plan {
+ LogicalPlan::TableScan(table_scan) => {
+ // TODO: support filters for table scan with alias
+ if alias.is_some() && !table_scan.filters().is_empty() {
+ return not_impl_err!(
+ "Subquery alias is not supported for table scan with
pushdown filters"
+ );
+ }
Review Comment:
There are some issues with handling the table name prefix for the column. It
isn't simple. I think we can create another issue for it. See the example in
the unit tests.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
