fengys1996 commented on code in PR #26177:
URL: https://github.com/apache/datafusion/pull/26177#discussion_r4290023866
##########
datafusion/expr/src/planner.rs:
##########
@@ -266,7 +266,11 @@ pub trait ExprPlanner: Debug + Send + Sync {
/// Plans scalar functions, such as `ABS(<expr>)`
///
/// Returns the original scalar function if not possible
- fn plan_scalar(&self, expr: RawScalarExpr) ->
Result<PlannerResult<RawScalarExpr>> {
+ fn plan_scalar(
Review Comment:
I took another look and checked the 55.0.0 and 55.2.0 tags, and
`ExprPlanner::plan_scalar` isn't present in either. It was introduced in
\#24846 for the upcoming 56.0.0 release, so this signature change doesn't
affect an API from a previous release. Given that, could we consider this PR
non-breaking? 😄
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
