alamb commented on code in PR #26177:
URL: https://github.com/apache/datafusion/pull/26177#discussion_r4283393866
##########
datafusion/expr/src/planner.rs:
##########
@@ -266,7 +266,11 @@ pub trait ExprPlanner: Debug + Send + Sync {
/// Plans scalar functions, such as `ABS(<expr>)`
///
/// Returns the original scalar function if not possible
- fn plan_scalar(&self, expr: RawScalarExpr) ->
Result<PlannerResult<RawScalarExpr>> {
+ fn plan_scalar(
Review Comment:
can you please add a note in the upgrade guide for this change as it is an
API change?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
