dwsmith1983 commented on code in PR #5867:
URL: https://github.com/apache/datafusion-comet/pull/5867#discussion_r4271389746
##########
spark/src/main/scala/org/apache/comet/serde/arrays.scala:
##########
@@ -788,7 +865,7 @@ object CometArrayReverse extends
CometExpressionSerde[Reverse] with ArraysBase {
}
-object CometElementAt extends CometExpressionSerde[ElementAt] {
+object CometElementAt extends CometExpressionSerde[ElementAt] with
CodegenDispatchFallback {
Review Comment:
One change since: the check no longer looks at
`spark.sql.subexpressionElimination.enabled`. Spark's whole-stage codegen
aggregates share the subexpressions of their update expressions even with it
off, so `max(element_at(m1, 1.0D/x)), max(element_at(m2, 1.0D/x))` still raises
there, and the dispatched lookups would not have. These shapes now fall back
whatever the setting says.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
