dwsmith1983 commented on code in PR #5867:
URL: https://github.com/apache/datafusion-comet/pull/5867#discussion_r4298048784
##########
spark/src/main/scala/org/apache/comet/serde/arrays.scala:
##########
@@ -925,10 +1013,16 @@ object CometArrayPosition extends
CometExpressionSerde[ArrayPosition] with Array
}
}
-object CometArraysZip extends CometExpressionSerde[ArraysZip] {
+object CometArraysZip extends CometExpressionSerde[ArraysZip] with
CodegenDispatchFallback {
Review Comment:
#6712 is on main now and merged here. Your query is a case in
`arrays_zip_nondeterministic_child.sql`
(f04ecf9521f1904d20326efde5b9fe6e7814cf92). Without #6712 it fails on this
branch with `b` at 4..7, and with it, it passes on Spark 3.5, 4.0 and 4.1. The
marker also requires `monotonically_increasing_id` to run inside the dispatched
kernel, so the test can't pass by evaluating it natively.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
