kosiew commented on code in PR #25825: URL: https://github.com/apache/datafusion/pull/25825#discussion_r4266524275
########## datafusion/sqllogictest/test_files/aggregate_memory_spill.slt: ########## @@ -61,7 +64,7 @@ FROM ( ) ---- <slt:ignore> -04)------AggregateExec: mode=Single, gby=[v@0 * 7 % 100000 as t.v * Int64(7) % Int64(100000)], aggr=[sum(t.v)], metrics=[<slt:ignore>spill_count=7,<slt:ignore>] +04)------AggregateExec: mode=Single, gby=[v@0 * 7 % 100000 as t.v * Int64(7) % Int64(100000)], aggr=[sum(t.v)], metrics=[<slt:ignore>spill_count=<slt:ignore>, spilled_rows=<slt:ignore> K,<slt:ignore>] Review Comment: The added `spill_count=` anchor still doesn't guarantee that the target aggregate spilled. The unrestricted wildcard after `spilled_rows=` can match ` K,` from a later operator's `output_rows`, and all six Cases A–F still pass with spilling disabled. Please assert a positive spill metric for the target aggregate in Cases A–G and verify that each no-spill case fails. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
