kosiew commented on code in PR #25825: URL: https://github.com/apache/datafusion/pull/25825#discussion_r4256684027
########## datafusion/sqllogictest/test_files/aggregate_memory_spill.slt: ########## @@ -61,7 +61,7 @@ FROM ( ) ---- <slt:ignore> -04)------AggregateExec: mode=Single, gby=[v@0 * 7 % 100000 as t.v * Int64(7) % Int64(100000)], aggr=[sum(t.v)], metrics=[<slt:ignore>spill_count=7,<slt:ignore>] +04)------AggregateExec: mode=Single, gby=[v@0 * 7 % 100000 as t.v * Int64(7) % Int64(100000)], aggr=[sum(t.v)], metrics=[<slt:ignore>spilled_rows=<slt:ignore>K,<slt:ignore>] Review Comment: This assertion can pass with `spilled_rows=0` because the wildcard can skip into a later operator and match the `K,` in `output_rows=100.0 K,`. I reproduced this in all six cases with a 128M memory limit and no spilling. Could you update Cases A–F to check a positive spill metric on the target aggregate directly, and verify that each test fails when spilling does not occur? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
