VVKot commented on code in PR #26007:
URL: https://github.com/apache/datafusion/pull/26007#discussion_r4177128280
##########
dev/update_datafusion_versions.py:
##########
@@ -151,18 +97,11 @@ def main():
print(f'Updating workspace in {repo_root} to {new_version}')
update_workspace_version(new_version)
- print(f'Updating datafusion crate versions in {repo_root} to
{new_version}')
- for cargo_toml in crates.values():
- update_datafusion_version(cargo_toml, new_version)
-
- print(f'Updating datafusion dependency versions in {repo_root} to
{new_version}')
- for cargo_toml in crates.values():
- update_downstream_versions(cargo_toml, new_version)
-
update_docs("README.md", new_version)
update_docs("docs/source/download.md", new_version)
update_docs("docs/source/user-guide/example-usage.md", new_version)
update_docs("docs/source/user-guide/crate-configuration.md", new_version)
+ update_docs("docs/source/user-guide/configs.md", new_version)
Review Comment:
`created_by` seems to be the default from `55.1.0` but the script will keep
updating it
https://github.com/apache/datafusion/pull/26007#pullrequestreview-5405320302 ,
which is misleading
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
