nuno-faria commented on code in PR #26007:
URL: https://github.com/apache/datafusion/pull/26007#discussion_r4174290176
##########
dev/update_datafusion_versions.py:
##########
@@ -26,29 +26,6 @@
from pathlib import Path
import tomlkit
-crates = {
- 'datafusion-common': 'datafusion/common/Cargo.toml',
- 'datafusion-common-runtime': 'datafusion/common-runtime/Cargo.toml',
- 'datafusion': 'datafusion/core/Cargo.toml',
- 'datafusion-execution': 'datafusion/execution/Cargo.toml',
- 'datafusion-expr': 'datafusion/expr/Cargo.toml',
- 'datafusion-ffi': 'datafusion/ffi/Cargo.toml',
- 'datafusion-functions': 'datafusion/functions/Cargo.toml',
- 'datafusion-functions-aggregate':
'datafusion/functions-aggregate/Cargo.toml',
- 'datafusion-functions-nested': 'datafusion/functions-nested/Cargo.toml',
- 'datafusion-optimizer': 'datafusion/optimizer/Cargo.toml',
- 'datafusion-physical-expr': 'datafusion/physical-expr/Cargo.toml',
- 'datafusion-physical-expr-common':
'datafusion/physical-expr-common/Cargo.toml',
- 'datafusion-physical-plan': 'datafusion/physical-plan/Cargo.toml',
- 'datafusion-proto': 'datafusion/proto/Cargo.toml',
- 'datafusion-sql': 'datafusion/sql/Cargo.toml',
- 'datafusion-sqllogictest': 'datafusion/sqllogictest/Cargo.toml',
- 'datafusion-substrait': 'datafusion/substrait/Cargo.toml',
- 'datafusion-wasmtest': 'datafusion/wasmtest/Cargo.toml',
- 'datafusion-benchmarks': 'benchmarks/Cargo.toml',
- 'datafusion-cli': 'datafusion-cli/Cargo.toml',
- 'datafusion-examples': 'datafusion-examples/Cargo.toml',
-}
Review Comment:
This was not catching everything, and is also not needed since all crates
start with "datafusion".
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
