VVKot commented on code in PR #26007:
URL: https://github.com/apache/datafusion/pull/26007#discussion_r4176981070
##########
dev/update_datafusion_versions.py:
##########
@@ -64,47 +41,15 @@ def update_workspace_version(new_version: str):
doc = tomlkit.parse(data)
- for crate in crates.keys():
- df_dep = doc.get('workspace').get('dependencies', {}).get(crate)
+ for crate, df_dep in doc['workspace']['dependencies'].items():
+ if not crate.startswith('datafusion'):
Review Comment:
Per your above comment, this seems like a reasonable way to enumerate all
crates _now_ - but I don't know if that will always be the case.
Would love one of the committers to opine whether we can expect all crate
names to start with `datafusion`
##########
dev/release/README.md:
##########
@@ -90,22 +90,18 @@ git push -u apache branch-50 # push branch to apache remote
### 2. Prepare PR to Update the Release Version
-Manually update the DataFusion version in the root `Cargo.toml` to
-reflect the new release version. Ensure `Cargo.lock` is updated accordingly by
-running:
+Update the DataFusion version using the following Python script:
```shell
-cargo check -p datafusion
+# replace NEW_VERSION before executing (e.g., 50.0.0)
+python3 dev/update_datafusion_versions.py NEW_VERSION
```
-Within the user documentation there are references to the current version
number.
-Update these to the current version. At the time of this writing we need to
manually
-update the following files
+This updates the DataFusion version across all files, including documentation.
The only extra step required is to update the `Cargo.lock` file, using the
following command:
Review Comment:
It does sound like the manual `cargo check` is actually needed? For me, the
script is updating Cargo.lock automatically, and `cargo check -p datafusion`
produces no new diff
##########
dev/update_datafusion_versions.py:
##########
@@ -151,18 +97,11 @@ def main():
print(f'Updating workspace in {repo_root} to {new_version}')
update_workspace_version(new_version)
- print(f'Updating datafusion crate versions in {repo_root} to
{new_version}')
- for cargo_toml in crates.values():
- update_datafusion_version(cargo_toml, new_version)
-
- print(f'Updating datafusion dependency versions in {repo_root} to
{new_version}')
- for cargo_toml in crates.values():
- update_downstream_versions(cargo_toml, new_version)
-
update_docs("README.md", new_version)
update_docs("docs/source/download.md", new_version)
update_docs("docs/source/user-guide/example-usage.md", new_version)
update_docs("docs/source/user-guide/crate-configuration.md", new_version)
+ update_docs("docs/source/user-guide/configs.md", new_version)
Review Comment:
see my top-level comment - `update_docs` is a bit too naive to properly
update `configs.md`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
