NoahKusaba commented on PR #19: URL: https://github.com/apache/datafusion-iceberg/pull/19#issuecomment-5882414395
@mbutrovich Opened #22 for the unpartitioned gap, with your repro. It covers both sides: - **Unpartitioned:** `IcebergWriteExec` passes the input's schema as the sink schema to `execute_input_stream`, so `check_not_null_constraints` never runs and NULLs land in required columns as `0`. - **Partitioned:** a nullable source column into a required one is rejected at plan time, even when it holds no NULLs. I'd like to keep this PR to the narrower fix, accepting NOT NULL sources into optional columns, and leave the plan-time rejection as it is. Once #22 passes the table's schema as the sink schema, that rejection can be dropped in favour of DataFusion's runtime check, and both paths will behave the same. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
