NoahKusaba commented on PR #19: URL: https://github.com/apache/datafusion-iceberg/pull/19#issuecomment-5882268606
Thanks for testing this so thoroughly, @mbutrovich. Agreed on the unpartitioned gap: because the sink schema is the input's own schema, `check_not_null_constraints` never runs. I'll open an issue that covers both sides, the unpartitioned path writing NULLs into required columns and the partitioned path rejecting nullable sources at plan time, with passing the table's Arrow schema (plus the partition column) as the sink schema as the likely fix for both. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
