xudong963 commented on issue #22883: URL: https://github.com/apache/datafusion/issues/22883#issuecomment-5881609874
> [@xudong963](https://github.com/xudong963) I don't quite follow what you are saying here. Are you saying you prefer [#25760](https://github.com/apache/datafusion/pull/25760) ? For the API we ultimately merge, I lean toward the FilterConjunct / PhysicalFilter approach in #25760. Optionality seems to be a property of a conjunct at a particular plan site, rather than a property of PhysicalExpr. I meant that the wrapper is a low-churn way to prototype the adaptive behavior on a draft branch, not that we should merge it as the public API and migrate later. My remaining concern with #25760 is the positional reassociation of optional flags through expression-only pushdown interfaces: I would like to make sure a rewrite or reorder cannot attach a flag to the wrong expression. Overall, I like the direction of #25760. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
