alamb commented on issue #22883: URL: https://github.com/apache/datafusion/issues/22883#issuecomment-5868874755
> Its strongest idea is separating two questions: whether a filter is required for correctness, and whether evaluating it is worthwhile on the current data. Yes, I agree formalizing this notion would be a very nice improvement > My preference is to use the wrapper for this experimental stack. For a longer-lived public mechanism, I would favor FilterConjunct once the expression and its metadata can travel through rewrites as one unit, without relying solely on positional reassociation. @xudong963 I don't quite follow what you are saying here. Are you saying you prefer https://github.com/apache/datafusion/pull/25760 ? I also reviewed (and really like) the `FilterConjunct` / `PhysicalFilter` API in - https://github.com/apache/datafusion/pull/25760 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
