LucaCappelletti94 opened a new pull request, #2567: URL: https://github.com/apache/datafusion-sqlparser-rs/pull/2567
AST equality ignores spans, so no existing test notices a wrong one. For every SQL string parsed through `TestedDialects`, and for each of its dialects, this checks four things: 1. The statement must span its first to last token. 2. Every node must lie inside its parent and be empty only when it renders nothing. 3. Nodes with a parser entry point must parse back from the source under their span. 4. All other nodes must start and end on their rendered tokens, which flags `LEFT JOIN b ON a.x = b.x` because the `Join` span starts at `b`. About three quarters of statements fail today 🤦🏻, so the known failures are listed in `tests/span_baseline.tsv`. A test fails on a new failure and also on a listed one that no longer occurs. A CI job records it again to catch stale lines, as described in `docs/span_oracle.md`. The checks run under `--all-features` only and add about 3 s to the test run. Closes #1563, part of #1548. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
