mizulun opened a new pull request, #6173: URL: https://github.com/apache/datafusion-comet/pull/6173
## Which issue does this PR close? Closes #5813. ## Rationale for this change The `CometRegex` whitelist depends on the behavior of the Rust `regex` crate. A dependency upgrade could change matching results or reject an admitted pattern without the existing corpus detecting it. Committed Java-generated fixtures provide a stable baseline for detecting these changes directly in Rust tests. ## What changes are included in this PR? - Add a standalone JDK 17 generator and 4,989 committed fixtures using `Pattern.matcher(subject).find()` as the oracle. - Cover admitted regex constructs, combinations, empty matches, Unicode, control characters, and patterns near structural admission limits. - Test scalar and UTF-8 array evaluation through Rust `RLike`, reporting fixture details on compilation errors or result mismatches. - Verify fixture admission and Java results in `CometRegexSuite`. - Document generation and JDK provenance, use Unicode escapes for locale-independent generation, and exclude fixture JSON from release RAT. The Rust fixture test does not start a JVM. Production execution and whitelist behavior are unchanged. ## How are these changes tested? - Rust `rlike` tests: all 7 passed after the Unicode fixture correction. - `CometRegexSuite` and `CometRegexParitySuite`: all 18 passed before the Unicode correction; rerun against the corrected fixtures is pending. - Regeneration under C and UTF-8 locales produces byte-identical output matching the committed fixtures. - Verified the expected Unicode subjects are present and no replacement characters occur. - Native build, formatting, and Maven RAT checks passed before the Unicode correction. - Verified the release RAT exclusion with its filtering script; the full release RAT check has not been run. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
