ranflarion commented on code in PR #24820:
URL: https://github.com/apache/datafusion/pull/24820#discussion_r3986301118
##########
datafusion/physical-plan/src/joins/nested_loop_join.rs:
##########
@@ -3440,6 +3535,272 @@ pub(crate) mod tests {
Arc::new(TestMemoryExec::update_cache(&source))
}
+ /// A build side that already arrives in target-sized batches is retained
as-is: the chunks
Review Comment:
Dropped join_left_data_drops_zero_row_chunks, the execution-level
join_across_build_chunk_boundaries covers the row translation and I
mutation-tested it against the same faults. Kept
build_side_chunks_reuse_the_input_buffers with its goal stated in one line: it
asserts by buffer pointer that a build side arriving at target size is retained
without a copy, which is the property this PR exists for and which no
sqllogictest can observe since the results are identical either way.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
