2010YOUY01 commented on PR #24820: URL: https://github.com/apache/datafusion/pull/24820#issuecomment-5631366341
This is the main part I'd suggest implementing differently. I'm happy to take it on myself — WDYT? Idea: https://github.com/apache/datafusion/pull/24820#discussion_r3986304462 I agree this seems optional if we only look at this PR. I feel strongly about this structure because we're likely to implement the same idea repeatedly in HJ and piecewise merge join, given https://github.com/apache/datafusion/issues/23076. A reusable struct would help there, so we don't have to handle the same complexity inside each operator. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
