Blizzara commented on code in PR #11597:
URL: https://github.com/apache/datafusion/pull/11597#discussion_r1723146039
##########
datafusion/substrait/src/logical_plan/producer.rs:
##########
@@ -658,8 +657,8 @@ fn to_substrait_jointype(join_type: JoinType) ->
join_rel::JoinType {
JoinType::Left => join_rel::JoinType::Left,
JoinType::Right => join_rel::JoinType::Right,
JoinType::Full => join_rel::JoinType::Outer,
- JoinType::LeftAnti => join_rel::JoinType::Anti,
- JoinType::LeftSemi => join_rel::JoinType::Semi,
+ JoinType::LeftAnti => join_rel::JoinType::LeftAnti,
+ JoinType::LeftSemi => join_rel::JoinType::LeftSemi,
Review Comment:
needed due to bumping substrait - I think this is just a compile-time break
tho, the actual protobuf values stay the same
##########
datafusion/substrait/src/logical_plan/consumer.rs:
##########
@@ -877,8 +884,8 @@ fn from_substrait_jointype(join_type: i32) ->
Result<JoinType> {
join_rel::JoinType::Left => Ok(JoinType::Left),
join_rel::JoinType::Right => Ok(JoinType::Right),
join_rel::JoinType::Outer => Ok(JoinType::Full),
- join_rel::JoinType::Anti => Ok(JoinType::LeftAnti),
- join_rel::JoinType::Semi => Ok(JoinType::LeftSemi),
+ join_rel::JoinType::LeftAnti => Ok(JoinType::LeftAnti),
+ join_rel::JoinType::LeftSemi => Ok(JoinType::LeftSemi),
Review Comment:
needed due to bumping substrait - I think this is just a compile-time break
tho, the actual protobuf values stay the same
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
