Blizzara commented on code in PR #11597:
URL: https://github.com/apache/datafusion/pull/11597#discussion_r1723141291
##########
datafusion/substrait/src/logical_plan/consumer.rs:
##########
@@ -1465,22 +1501,10 @@ fn from_substrait_type(
"Unsupported Substrait type variation {v} of type
{s_kind:?}"
),
},
- r#type::Kind::IntervalYear(i) => match i.type_variation_reference {
- DEFAULT_TYPE_VARIATION_REF => {
- Ok(DataType::Interval(IntervalUnit::YearMonth))
- }
- v => not_impl_err!(
- "Unsupported Substrait type variation {v} of type
{s_kind:?}"
- ),
- },
- r#type::Kind::IntervalDay(i) => match i.type_variation_reference {
- DEFAULT_TYPE_VARIATION_REF => {
- Ok(DataType::Interval(IntervalUnit::DayTime))
- }
- v => not_impl_err!(
- "Unsupported Substrait type variation {v} of type
{s_kind:?}"
- ),
- },
+ r#type::Kind::IntervalYear(_) => {
+ Ok(DataType::Interval(IntervalUnit::YearMonth))
+ }
+ r#type::Kind::IntervalDay(_) =>
Ok(DataType::Interval(IntervalUnit::DayTime)),
Review Comment:
this was just cleanup - we don't check type variations for types where we
don't use them
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
