Blizzara commented on code in PR #11597:
URL: https://github.com/apache/datafusion/pull/11597#discussion_r1723144677
##########
datafusion/substrait/src/logical_plan/consumer.rs:
##########
@@ -1881,10 +1943,24 @@ fn from_substrait_literal(
Some(LiteralType::IntervalDayToSecond(IntervalDayToSecond {
days,
seconds,
- microseconds,
+ subseconds,
+ precision_mode,
})) => {
- // DF only supports millisecond precision, so we lose the micros
here
- ScalarValue::new_interval_dt(*days, (seconds * 1000) +
(microseconds / 1000))
+ // DF only supports millisecond precision, so for any more
granular type we lose precision
Review Comment:
these changes were needed as part of bumping substrait
(https://github.com/substrait-io/substrait/pull/665)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
