peterxcli commented on PR #5493: URL: https://github.com/apache/datafusion-comet/pull/5493#issuecomment-5503771086
Addressed the follow-up review in 59b7cf2b2: extracted the shared partition-writer cleanup; corrected the task-confined comments and allocator contract; skipped the sibling sort after a sufficient self-spill; and expanded the three-writer regression with a 900 KiB row that requires two sibling spills. I also updated the PR description with the independent single-task crash and benchmark figures. Local validation: make format, make core, and CometDiskBlockWriterSuite 9/9. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
