jayzhan211 commented on code in PR #12043:
URL: https://github.com/apache/datafusion/pull/12043#discussion_r1720766294
##########
datafusion/proto/tests/cases/roundtrip_logical_plan.rs:
##########
@@ -904,7 +904,7 @@ async fn roundtrip_expr_api() -> Result<()> {
vec![lit(1), lit(2), lit(3)],
vec![lit(10), lit(20), lit(30)],
),
- row_number(vec![col("a")]),
Review Comment:
If we did the signature check, this test should fail. Because the signature
is `Any(0)`, which should only accept zero arguments
The reason why it is not is because we didn't do signature check for window
udf.
We have similar functions for scalar and udaf.
https://github.com/apache/datafusion/blob/cb1e3f0e5cfd04195ae0c933b74f3eb3fcbe1b45/datafusion/expr/src/type_coercion/functions.rs#L42-L96
`data_types_with_scalar_udf` and `data_types_with_aggregate_udf`.
After adding a new `data_types_with_window_udf` function, we should get the
failed msg for incorrect non-empty args for `row_number`
Maybe add it somewhere here
https://github.com/apache/datafusion/blob/cb1e3f0e5cfd04195ae0c933b74f3eb3fcbe1b45/datafusion/expr/src/expr_schema.rs#L169-L196
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
